added potential scraping name for Ridley

Frannsoft / FrannHammer

Restful api for Smash 4 and Ultimate frame data as told by KuroganeHammer.

MIT License

42 stars 0 forks source link

added potential scraping name for Ridley #295

Closed dunnaaron closed 5 years ago

dunnaaron commented 5 years ago

Ridley is not returning a thumbnail, added a potential scraping name.

Frannsoft commented 5 years ago

Confirmed this a bug.

Does this change find the img element when attempting to pull Ridley's thumbnail? Looking at the dom for the KH website, I think the potentialScrapingNames value needed would be Not Lucas (ha).

dunnaaron commented 5 years ago

Oh my, yeah you're right. I'll change it and update the PR.

Frannsoft commented 5 years ago

Can you edit the base branch in the PR to be ultimate-support? Right now it's set to merge into master.

After that, this looks good to go.