Ultimate api only returns 48 characters instead of 86

Frannsoft / FrannHammer

Restful api for Smash 4 and Ultimate frame data as told by KuroganeHammer.

MIT License

42 stars 0 forks source link

Ultimate api only returns 48 characters instead of 86 #304

Closed locl95 closed 2 years ago

locl95 commented 2 years ago

I would expect to get all characters from ultimate in the /api/characters?game=ultimate call. Right now I'm only getting 48.

Frannsoft commented 2 years ago

Hi!

Thanks for using the api!

It's been a while since I've messed with this code, but I believe this is because there is only data on the Kurogane Hammer website for that amount of characters.

This API pulls data from the Kurogane Hammer website so if the website's page for a character doesn't have any frame data that character in Ultimate, the api won't return data for that character.

locl95 commented 2 years ago

I see, makes sense then. Tyvm for quick response