FransBouma / ShaderToggler

Reshade 5+ addin to toggle shaders on/off in groups based on a key press. It allows you to configure these groups from within the addin as well.
MIT License
101 stars 28 forks source link

Permanent\disable groups #10

Closed v00d00m4n closed 1 year ago

v00d00m4n commented 2 years ago

Would be nice if you can mark some separate groups of shaders as permanent or disabled on start.

Because its annoying to togle it every time and its better to set and forget some of groups while keep other off.

For example shader could be unified for menu and hud, its good idea to start without hiding shader, but then toggle it when level loads.

In other case some shaders could be safe to hide from start, so an option to keep something disabled permanently or just disable it for current session is nice.

Also sticky toggle would work as well, is group would have setting that will allow state to be saved, so you run game once and toggle on, it keeps for next launch, but then you toggle off and keeps that way until next toggle.

John-Dean commented 1 year ago

I've written a small amendment here: https://github.com/John-Dean/ShaderToggler that changes the default state to the group toggled on which is what I needed for my use case.

I know it's not a full fix, but there doesn't seem to be any plan to update this.

https://github.com/John-Dean/ShaderToggler

blackwind commented 1 year ago

Would you be so kind as to provide a 64-bit build as well, @John-Dean?

John-Dean commented 1 year ago

@blackwind As far as I'm aware there is a 64-bit build in the releases of that repo, at least I'm using it on a 64-bit install with no issues.

On Tue, 12 Sept 2023, 04:59 blackwind, @.***> wrote:

Would you be so kind as to provide a 64-bit build as well, @John-Dean https://github.com/John-Dean?

— Reply to this email directly, view it on GitHub https://github.com/FransBouma/ShaderToggler/issues/10#issuecomment-1714890747, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJKH2YI4TQRPAT3UU4BDQDXZ7FZRANCNFSM57GHIRQA . You are receiving this because you were mentioned.Message ID: @.***>

blackwind commented 1 year ago

@John-Dean The main repo here has a .addon version and a .addon64 version. The .addon64 version is required for 64-bit games, which is of course distinct from your 64-bit OS running 32-bit games with the .addon available in your repo.

FransBouma commented 1 year ago

I released a 32bit version once but it was merely a one-time thing.

ReShade made the addon extension addon64 and addon32 to signal the variant some time ago and newer versions of the addons I make have that newer extension. You can just rename it to whatever you want as long as reshade recognizes it.

blackwind commented 1 year ago

Interesting, thanks for the clarification, Frans!

blackwind commented 1 year ago

While we have you, any chance we'll see an official solution for this? I've always been curious what the use case is for defaulting to inactive. If I went to all the trouble of isolating shaders to be disabled, why wouldn't I want that done automatically in most, if not all cases?

FransBouma commented 1 year ago

Maybe in the future, I'm not going to implement it at this point. It's 1 key press to disable the shaders...

blackwind commented 1 year ago

Which is easy when you're at the computer with a keyboard, and much less so when you're on the couch with a controller. Just some food for thought.

FransBouma commented 1 year ago

Please don't act like this is a major issue and it needs to be fixed asap. I wrote this in my spare time, I can't just drop everything and work on this. Like I said, maybe in the future if I have time and energy to build this in. Maybe someone will send me a PR, maybe it will never happen.

FransBouma commented 1 year ago

Implemented in 1.2

FransBouma commented 1 year ago

1.2 is now available