Persist group active states

[blackwind]

Simple, elegant two-line solution to #10. Group active states are now saved to file when a save is requested and read back in on launch. No impact to existing users, as the default remains false.

[FransBouma]

the user experience isn't that great tho. the user has to first setup the active toggles the way they want to, click save and if they want to change a toggle, they have to save the file again (to keep the changed shader hashes) but also make sure the toggles they want to have permanent are active at that point.

I think this requires a checkbox for the toggle group to mark them 'permanent' or 'sticky', or 'active by default' (default normally is off), so this doesn't rely on whether people have the right toggles active when clicking the save button. So basically when the groups are created the user has to specify the default: default off or default on. That's extra data that's not depending on the state of the toggle when the save button is clicked.

[blackwind]

I hear what you're saying, but again, I question the use case. For the power user like me, I want to create a preset or two, activate them as appropriate, hit save, and never open ReShade or think about it again. I don't even need the hotkeys except to debug what's happening when I realize, "Wait... isn't there supposed to be a giant dragon here?" Likewise, for Joe Average, they want to download a .ini, stick it in their folder, and never think about it again. You've proposed significant extra complexity for both the add-on author (or PR author) and the user, under the premise that people are routinely going in and making changes to their profiles. I just don't see that as a common use case, nor do I see the changes made here being prohibitively difficult to internalize for those select few ultra power users.

From a user experience perspective, when I make changes to the add-on and hit save, I expect all my changes, including active states, to save. To me, that makes the most sense, and I say that as someone who's spent considerable time in his career weighing user experience considerations. But let's open it up to the participants from the original issue.

CC: @v00d00m4n @John-Dean @SweetLoli @haywirephoenix

What do you guys think?

[FransBouma]

You can debate this till the cows come home, how the PR is at this point I'm not going to merge this as there are problems I have to deal with.

As I have to merge another PR today I'll see what I can do, but no promises.

[FransBouma]

Implemented in 1.2

[FransBouma]

1.2 is now available