FraserChapman / plunger

A Youtube adblock-block-un-blocker browser extension
MIT License
15 stars 2 forks source link

i18n contributions where? #4

Open momoblydblk opened 9 months ago

momoblydblk commented 9 months ago

Is your feature request related to a problem? Please describe. Where do I contribute to the translation of this?

Describe the solution you'd like Where do I contribute to the translation of this?

Describe alternatives you've considered Where do I contribute to the translation of this?

Additional context Where do I contribute to the translation of this?

FraserChapman commented 9 months ago

Hi @momoblydblk

Currently the plugin supports setting the language for the controls of the embedded player.

See the Interface language input in...

https://github.com/FraserChapman/plunger/blob/main/src/popup.html

This parameter specifies the player's interface language.

The parameter value is an ISO 639-1 two-letter language code or a fully specified locale. For example, fr and fr-ca are both valid values. Other language input codes, such as IETF language tags (BCP 47) might also be handled properly.

The interface language is used for tooltips in the player and also affects the default caption track. Note that YouTube might select a different caption track language for a particular user based on the user's individual language preferences and the availability of caption tracks.

If you mean translations for the options themselves - such as the "Automatically play videos", "Show closed captions", "Display player controls", etc - currently these are not localised and there is no mechanism to do it as yet...

Pleases feel free to add a pull request that adds this functionality if you like :)

momoblydblk commented 9 months ago

Hi, @FraserChapman

By translation I mean translating of the main page, which contains options like "Automatically play videos" and so on. Sad to hear that there isn't an option for that.

As for PR for new function ... I don't mainly write in Javascript so sorry about that.

Thanks

PS: Feel free to contact me if you want to add translation for this. I can do en-US to and back from zh-CN