FraserLee / bevy_sprite3d

Use sprites in a 3d bevy scene.
MIT License
145 stars 23 forks source link

Replace `partial_alpha` with `alpha_mode` field #13

Closed bardt closed 1 year ago

bardt commented 1 year ago

As discussed in https://github.com/FraserLee/bevy_sprite3d/issues/12 there might be a need for more flexibility in which AlphaMode is applied to the sprite material. Having 2 parameters related to alpha would be confusing, so I decided to replace partial_alpha with an optional alpha_mode with docs matching in spirit.

Migration guide:

FraserLee commented 1 year ago

Just a few small nitpicks, this looks great!

FraserLee commented 1 year ago

Thanks for the PR!

bardt commented 1 year ago

@FraserLee thanks for the quick responses and this amazing crate!