Closed z2Z6 closed 1 year ago
Hi, please check #1024 and let us know if it resolves the issue. I think it works in this specific case but as I say in the PR, it may not fix related problems.
Hi, please check #1024 and let us know if it resolves the issue. I think it works in this specific case but as I say in the PR, it may not fix related problems.
Thanks for quick fix. I test some files with solution #1024, it fixed most of endless loop problems I now encounter, but still leave one as above.
the file is ApplicationMaster.java in https://github.com/Qihoo360/XLearning/blob/master/src/main/java/net/qihoo/xlearning/AM/ApplicationMaster.java
.
the worklist.size
keeps fluctuating, it seems to never decrease to zero.
That was exactly what I expected... I changed the PR a bit and the sample you sent should work with the new changes. Let me know if you encounter any other issues
That was exactly what I expected... I changed the PR a bit and the sample you sent should work with the new changes. Let me know if you encounter any other issues
All endless loop problems I now encounter are solved with new changes in #1024. There is no other new issue at present.
Hi @KuechA ,
There is a file(KDC.java) which has the same problem. It may need to relax the worklistHasSimilarPair
condition further.
Hi, #1088 should solve the problem for the mentioned file. If you encounter more problems, please reopen the issue or create a new one so we can keep track of the status more easily and your comments don't get lost ;)
Hi, Recently, I met with a file whose CPG can't be built successfully, because endless loop occured in
ControlFlowSensitiveDFGPass
when parsing it. The file is Runtime.java inhttps://github.com/RaiMan/SikuliX1/archive/refs/tags/1.1.3.zip
dump infomation(similar content in several times)
configuration: v5.1.0
For
ControlFlowSensitiveDFGPass.kt
,worklist.size
in funchandleFunction
keeps increasing when parsing Runtime.java, which causes endless loop. I guess the funcworklistHasSimilarPair
need to relax restrictions, which can avoid to add some similar pairs toworklist
frequently.