Fraunhofer-FIT-DSAI / drk-information-model

Datenraum Kultur (DRK) Information Model
3 stars 1 forks source link

Technical review of controlled vocabularies for representing DRK IM UC3 ENUMs #15

Open rohitadeshmukh13 opened 2 months ago

rohitadeshmukh13 commented 2 months ago

Technical review of the following controlled vocabularies :

Permalink to the vocabs folder in containing these repos: vocabs folder

p.s.: As this is the very first review of controlled vocabularies, a separate issue is dedicated to it. In the future, reviews can primarily happen directly in pull-requests, where possible.

clange commented 1 month ago

Overall, this looks great. Probably more than sufficient for the first release, so please do not consider the following points as blockers.

Would it not make sense if tevent:LastPerformance, tevent:Premiere and tevent:GuestPerformance had a common super-concept (i.e., a skos:broader)?

Similarly for, e.g., tgenres:ContemporaryDance and tgenres:Dance – shouldn't there be a relationship among them?

skos:exactMatch wikidata:Q1200301 .

Domain and range of skos:exactMatch are skos:Concept, but wikidata:Q12300301 is not a skos:Concept. At least not explicitly. Still, we might consciously decide to pretend so.

rdfs:seeAlso    <https://en.wikipedia.org/wiki/Premiere>

I would not link to the human-readable version of Wikipedia – rather just to Wikidata. Here, we are in the domain of a machine-comprehensible representation. If you want to link to Wikipedia (not Wikidata) in a "Semantic Web" way, consider the http://dbpedia.org/resource/ namespace.

Should tprod:WorldPremiere in some way be related to tevent:Premiere?