search

Fraunhofer-IIS / libjapi

libjapi is a universal JSON to C API library. It receives newline-delimited JSON (NDJSON) messages via TCP and calls registered C functions. A JSON response is returned for each request. Furthermore, it is also possible to create push services, which asynchronously push JSON messages to the clients subscribed to them.
MIT License
3 stars 1 forks source link

cmake: remove redundant compiler and linker flags - [merged] #104

Closed fraunhofer-iis-bot closed 1 year ago

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 21, 2020, 14:58

_Merges fixcmake -> dev

fraunhofer-iis-bot commented 4 years ago

In GitLab by @cstender on Apr 21, 2020, 16:08

Commented on CMakeLists.txt line 12

nachdem die Flags nichts mit dem Release zu tun haben, schau mal, ob man die nicht besser über target_compile_options setzt, siehe auch:

https://cmake.org/cmake/help/v3.11/command/target_compile_options.html

https://stackoverflow.com/questions/23995019/what-is-the-modern-method-for-setting-general-compile-flags-in-cmake

https://www.brianlheim.com/2018/04/09/cmake-cheat-sheet.html

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 22, 2020, 13:21

Commented on CMakeLists.txt line 12

changed this line in version 2 of the diff

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 22, 2020, 13:21

added 1 commit

Compare with previous version

fraunhofer-iis-bot commented 4 years ago

In GitLab by @cstender on Apr 22, 2020, 17:42

Commented on CMakeLists.txt line 70

ich glaube die Präprozessor-Flags gehören hier nicht rein, weil sie nur den C Code betreffen? Bitte auch prüfen, ob es -phtread hier braucht.

fraunhofer-iis-bot commented 4 years ago

In GitLab by @cstender on Apr 22, 2020, 17:43

Commented on CMakeLists.txt line 24

Nachdem es weder "Multicore" noch "Präprozessor-Flags" sind würde ich sie hier einfach auflisten.

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 08:53

Commented on CMakeLists.txt line 70

changed this line in version 3 of the diff

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 08:53

Commented on CMakeLists.txt line 24

changed this line in version 3 of the diff

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 08:53

added 1 commit

Compare with previous version

fraunhofer-iis-bot commented 4 years ago

In GitLab by @cstender on Apr 23, 2020, 09:38

resolved all threads

fraunhofer-iis-bot commented 4 years ago

In GitLab by @fraunhofer-iis-anon on Apr 23, 2020, 11:41

added 1 commit

Compare with previous version

fraunhofer-iis-bot commented 4 years ago

In GitLab by @cstender on Apr 23, 2020, 13:38

merged

fraunhofer-iis-bot commented 4 years ago

In GitLab by @cstender on Apr 23, 2020, 13:38

mentioned in commit 7f1ced6cd4ab84cc0c59015d1ada98c83c8b9555