search

Fraunhofer-IIS / mpeghdec

The Fraunhofer MPEG-H decoder (mpeghdec) is a C/C++ implementation of the MPEG-H Audio standard as defined in ISO/IEC 23008-3:2022
Other
61 stars 7 forks source link

use https git instead of ssh in CMakeLists.txt? #2

Closed aureliendavid closed 1 year ago

aureliendavid commented 1 year ago

Hello,

The cmake script gets its dependencies from git in ssh mode at

https://github.com/Fraunhofer-IIS/mpeghdec/blob/70fbbde01a08406b114fbcaf6a246fbe7b97b93c/CMakeLists.txt#L14-L24

this fails when the key is not linked to a github user, even for public repos

using git in https would allow for wider support

would you consider changing it?

thanks

mhildenbrand-iis commented 1 year ago

Hello David,

Yes, we are going to change this.

Best, Matthias

mhildenbrand-iis commented 1 year ago

Now committed on the main branch.