search

FraunhoferIOSB / camera_aravis

A ROS1 driver for GenICam based GigE and USB3 cameras.
Other
22 stars 15 forks source link

Pr extended camera info #11

Closed tonyromarock closed 2 years ago

tonyromarock commented 2 years ago

Hello Thomas,

in this PR we added the extended_camera_info message, that captures additional information about the camera acquisition process like the exposure time, gain, black level, white balance values and device temperature. The acquisition-related parameters are not covered in ROS 1 (ROS REP 104 also suggests providing this information in a dedicated topic). This message is only published when the ExtendedCameraInfo parameter is set.

Unfortunately, even with the GenICam standard there are not always uniform camera feature names to extract the white balance values. This PR only covers the GenICam cameras that conform the standard, as well as the special feature names used by Basler, JAI and TIS cameras.

The two previous commits remove unnecessary warning messages from aravis when parsing for feature names not available in some cameras and makes sure that the ROI values set in the standard CameraInfo are correctly considered, when rectifying a cropped camera image.

Let me know what you think of this PR.

Best regards, Peter

thomasemter commented 2 years ago

Hi Peter,

thank you very much for the useful additon and improvements.

Bets regards, Thomas