FreakyAli / Maui.FreakyControls

FreakyControls is a free OSS UI Kit for .NET MAUI which provides a set of controls and utilities to build modern mobile apps.
MIT License
316 stars 38 forks source link

[0.4.12-pre] SKCanvasView Compile error #126

Closed sk1llsh0t closed 5 months ago

sk1llsh0t commented 6 months ago

Description

Maybe you are already aware of this issue but after updating to 0.4.12-pre, I am getting a couple compile errors on Android. Downgrading back to 0.4.11 fixes the issue.

image

Expected Behavior

Successful compile

Actual Behavior

Error is thrown at compile time

Basic Information

Screenshots

See screenshot of errors in Description

FreakyAli commented 5 months ago

Make sure you have the latest version of Skiasharp, clean your bin and obj and restart VS, this is not an issue with the plugin but a issue on your machine

sk1llsh0t commented 5 months ago

My project doesn't use skiasharp so I shouldn't have to install that package. I'll see if deleting everything in bin/obj folders fix the issue. I'll let you know.

FreakyAli commented 5 months ago

Your project uses FreakyControls, hence it uses skiasharp indirectly, make sure you update it to the latest at times vs doesn't do it

sk1llsh0t commented 5 months ago

I shouldn't have to maintain dependencies of dependencies. Then I need to keep track to the right versions of implicit dependencies to use for all my dependencies. It should implicitly pull in the right dependencies based on what is referenced. I shouldn't have to explicitly add a package to my project i'm not using directly. It is a recipe for disaster.

sk1llsh0t commented 5 months ago

I found this article which is my exact issue. https://github.com/dotnet/maui/issues/19645

sk1llsh0t commented 5 months ago

This project appears to have had the same issue: https://github.com/fdmomtaz/WeightTracker-DotNetMaui/issues/1

They had to make some changes to the project to take care of this error as well.

sk1llsh0t commented 5 months ago

Based on the weighttracker project mentioned above, he did the following commits to fix the issue...

https://github.com/fdmomtaz/WeightTracker-DotNetMaui/commit/b0966709d7ada5f3111a912fe2c8e3b853537ad3 https://github.com/fdmomtaz/WeightTracker-DotNetMaui/commit/4d1e1ba5c96b348aa264ef90d75708d1bca938a6

If i have time, i'll fork your develop branch, add these changes and see if the problem goes away. I'll let you know if it works...

FreakyAli commented 5 months ago

I shouldn't have to maintain dependencies of dependencies. Then I need to keep track of the right versions of implicit dependencies to use for all my dependencies. It should implicitly pull in the right dependencies based on what is referenced. I shouldn't have to explicitly add a package to my project I'm not using directly. It is a recipe for disaster.

As much as I agree there are times when this breaks and we have no control over this...