search

FreakyAli / Maui.FreakyControls

FreakyControls is a free OSS UI Kit for .NET MAUI which provides a set of controls and utilities to build modern mobile apps.
MIT License
294 stars 36 forks source link

Fix SkiaSharp missing resource errors #127

Closed sk1llsh0t closed 3 months ago

sk1llsh0t commented 3 months ago

Fix missing resources error compiling the SkiaSharp library dependency

sk1llsh0t commented 3 months ago

Fixes this issue: https://github.com/FreakyAli/Maui.FreakyControls/issues/126

FreakyAli commented 3 months ago

@sk1llsh0t I did some digging and it seems that the issue was introduced because I downgraded the SkiaSharp package in the pre-release version 0.4.12 which is likely why this issue is caused.

Previously I was using v2.88.6 and now I downgraded to 2.88.0, the only SkiaSharp change that was made. I did that so people didn't need to upgrade their packages to match our requirements, making the overall experience better for people with Skia dependency. Still, because of this, people who don't have SkiaSharp are facing the issue you are facing because v2.88.0 is installed by default which had this issue.

This is the reason things start working as soon as you downgrade, do you think I should change this back to what it was before?

sk1llsh0t commented 3 months ago

I'm fine with any solution that allows it to compile correctly. Whatever you think makes the most sense for your project. I just think it needs to compile for projects that don't use skiasharp directly.

FreakyAli commented 3 months ago

Going ahead with your solution makes more sense in the long run for sure since in that case people don't need to upgrade their packages, but then when they encounter a Skia specific bug they might have to do it anyway