search

FreakyAli / Maui.FreakyControls

FreakyControls is a free OSS UI Kit for .NET MAUI which provides a set of controls and utilities to build modern mobile apps.
MIT License
313 stars 37 forks source link

fix build errors #157

Open janusw opened 1 month ago

janusw commented 1 month ago
janusw commented 1 month ago

Btw, maybe an automatic CI build would be useful to catch such things? I could contribute some hooks for GitHub Actions, if desired ...

FreakyAli commented 1 month ago

@janusw I do have some CI hooks and stuff but they are incomplete, I also need to add tests the unfortunate thing is I have 0 time for the last 3 months

janusw commented 1 month ago

@janusw I do have some CI hooks and stuff but they are incomplete, I also need to add tests the unfortunate thing is I have 0 time for the last 3 months

Incomplete CI is much better than no CI at all ;) Why don't you simply activate what you have?

Or are you saying it's already running somewhere (where we don't see it)?

FreakyAli commented 1 month ago

I think you should be able to see it, its a github action check this location .github/workflows/main_ci.yml

It's also active as far as I can tell

janusw commented 1 month ago

I think you should be able to see it, its a github action check this location .github/workflows/main_ci.yml

Right, it's here (thanks for the pointer):

https://github.com/FreakyAli/Maui.FreakyControls/blob/master/.github/workflows/main_ci.yml

It's also active as far as I can tell

Actually I do not see it running anywhere.

First problem is: It's only configured to run on the master branch (upon push or PR), so it's not checking if the develop branch is broken, and it doens't check any PRs to develop.

And even on the master branch, it does not look like it has run for any of the latest commits. On the last commit, it seems like only main_cd.yml has run, and it failed 😢 https://github.com/FreakyAli/Maui.FreakyControls/actions/runs/11193473030/job/31118830311

For #154, it's awaiting your approval, apparently.

FreakyAli commented 1 month ago

Like I said it's incomplete and I am not finding much time to complete things!

janusw commented 4 weeks ago

I guess the first necessary step would be to merge your master branch into develop, so that the latter also receives the GHA workflows that were added on master. Could you please do that?

Then one can extend those workflows and make sure the build is working (I can help with that) ...