search

FreakyAli / Plugin.Maui.Biometric

A biometric plugin for .NET MAUI
MIT License
106 stars 11 forks source link

feat: A method to get all enrolled biometric types #6

Closed FreakyAli closed 5 months ago

robertmaxted commented 5 months ago

@FreakyAli looks good to me. Have you tested it before you release mate? Just to be sure..

FreakyAli commented 5 months ago

@robertmaxted Yes I tested Android, need to test iOS

robertmaxted commented 5 months ago

@FreakyAli brill, all working as expected? Ie provides fingerprint or face id as planned? Thanks again mate.

FreakyAli commented 5 months ago

@robertmaxted so I tested it a bit further, it seems that, it responds with whatever is enrolled that it finds first, on Android, so even if Face is enrolled it will respond with Fingerprint, if Fingerprint is enrolled!

robertmaxted commented 5 months ago

@FreakyAli Ahh damn.. ok.. I guess if fingerprint is enrolled (ie user has fingerprint biometric saved on device) it isn't an issue? Not ideal but at least it will only try if it has at least one enrolled..?

robertmaxted commented 5 months ago

@FreakyAli message me on discord, it will be much easier to discuss on there.. dazzling_fawn_39070

FreakyAli commented 5 months ago

@robertmaxted I have been off Discord for a while but I will see if I can reinstall it, also I was thinking we should maybe make this respond as an array of available options and show everything that is enrolled, it would be easier for sure but it's not like you can choose which authentication would be challenged to the user, it seems the os always decides it on Android

robertmaxted commented 5 months ago

@FreakyAli What's the sitch, are you going ahead with the merge? I was thinking about this. If both fingerprint and Face ID are enrolled on Android, the OS will chose the same kind every time (fingerprint) as it has stronger security. Therefore "we" can adjust our UI's accordingly (ie if fingerprint, inform user that fingerprint required etc).. I don't see an issue with that. However it is your repo so your call mate :).

FreakyAli commented 5 months ago

@robertmaxted I am gonna turn this into an array, and respond with whatever is available that makes more sense in the long-run if Google decides to fix their issue, on iOS it's always gonna face-id anyway...

robertmaxted commented 5 months ago

@FreakyAli Yeah that makes sense (well, for future reasons anyway haha). Cheers mate

robertmaxted commented 5 months ago

@FreakyAli Hi mate, any news of when this will be merged? Maybe go ahead with current implementation for now and incorporate the array in the future?

FreakyAli commented 5 months ago

@robertmaxted Won't be able to tell you for now, busy for this week, if i get a chance over the weekend i will try

robertmaxted commented 5 months ago

@FreakyAli Ok mate, many thanks.