Fred-grais / transifex-interface-ruby

A Transifex API interface written in ruby
MIT License
5 stars 12 forks source link

Introduce vcr for tests #4

Closed nirnaeth closed 7 years ago

nirnaeth commented 7 years ago

Use VCR to record the interaction with the transifex server. The tests weren't really working, given that to run them it was necessary to change the project and the structure of the project to fit the need. Using VCR, this can be avoided.

While recording the interactions, I have fixed a bug on the update methods in coordinators.rb, reviewers.rb and translators.rb. Using symbol keys was causing the method not to update the remote resource.

I have changed the spec_helper so that it gets rid of the files created during the suite run.

I have noticed that some other tests are missing, at first I started adding them, but then I thought it might be better to have them at a second time.

Hope this helps developing easier :)