Not all fans are updated

Fred78290 / nct6687d

Linux kernel module for Nuvoton NCT6687-R

GNU General Public License v2.0

212 stars 42 forks source link

Not all fans are updated #2

Closed ykurlaev closed 3 years ago

ykurlaev commented 3 years ago

In nct6687_update_fans you have for (i = 0; i < ARRAY_SIZE(data->rpm); i++), but size of data->rpm is always 3 (u16 rpm[3][NCT6687_NUM_REG_FAN];). Also, maybe it's good idea to add debug print that is already there for temperature and voltage update functions to the fan update function as well?

Fred78290 commented 3 years ago

Thanks for your report. I fixed the issue.