Fred78290 / nct6687d

Linux kernel module for Nuvoton NCT6687-R
GNU General Public License v2.0
215 stars 42 forks source link

Accept NCT6683D (0xc732) #42

Closed mpartel closed 2 years ago

mpartel commented 2 years ago

This chip controls the fans on ASRock Taichi B550.

I couldn't get fan control to work with any of the in-tree nct6* drivers, but it works with your driver after this change :+1:

Example lm-sensors output:

nct6683-isa-0a20
Adapter: ISA adapter
+12V:            0.00 V  (min =  +0.00 V, max =  +0.00 V)
+5V:             0.00 V  (min =  +0.00 V, max =  +0.00 V)
+3.3V:           0.00 V  (min =  +0.00 V, max =  +3.39 V)
CPU Soc:         0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU Vcore:       0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU 1P8:         0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU VDDP:        0.00 V  (min =  +0.00 V, max =  +0.00 V)
DRAM:            0.00 V  (min =  +0.00 V, max =  +0.00 V)
Chipset:         0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU Fan:          0 RPM  (min =    0 RPM, max =    0 RPM)
Pump Fan:         0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #1:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #2:  625 RPM  (min =    0 RPM, max =  645 RPM)
System Fan #3:  639 RPM  (min =    0 RPM, max = 1430 RPM)
System Fan #4:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #5:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #6:    0 RPM  (min =    0 RPM, max =    0 RPM)
CPU:            +33.0°C  (low  = +25.0°C, high = +38.0°C)
System:         +39.0°C  (low  = +31.0°C, high = +71.0°C)
VRM MOS:         +0.0°C  (low  =  +0.0°C, high =  +0.0°C)
PCH:             +0.0°C  (low  =  +0.0°C, high =  +0.0°C)
CPU Socket:      +0.0°C  (low  =  +0.0°C, high =  +0.0°C)
PCIe x1:         +0.0°C  (low  =  +0.0°C, high =  +0.0°C)
M2_1:            +0.0°C  (low  =  +0.0°C, high =  +0.0°C)

Some notes:

Fred78290 commented 2 years ago

Hello great news that my module can override nct6683 with readable value.

Could you explain me the last commit flag force because I don't see a reason.

Regards

mpartel commented 2 years ago

Your module declares the parameter force but didn't implement it.

The in-tree nct6683 also has this parameter, and I had to use it to get it to work even partially, so I thought implementing it for your module might be useful for someone in the future. Could also remove it entirely if you're not comfortable with it. I suppose it could be dangerous.

mpartel commented 2 years ago

^ a little follow-up to get the correct device name in lm-sensors.

Fred78290 commented 2 years ago

Sorry I forgive to accept PR