search

FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC
Other
6 stars 2 forks source link

ADCC GTL & Luciferase template #109

Open ruizhw19 opened 1 year ago

ruizhw19 commented 1 year ago

Hi Alicia and Bhavesh, I added biological endpoints, lab methods, statistical methods templates for ADCC GTL & Luciferase & ICABA ready for review:

slager commented 1 month ago

Merged in recent changes from develop so that reports can be run through the new CI / test knitting on this branch.

lemireg commented 3 weeks ago

Hello team @asatofh @slager @mayerbry,

Updated to incorporate most recent ADCC template code aligning with HVTN per: T:\vaccine\documents\templates\lab_assay_memos\ADCC-Flow_Memo_PT_Template_LS.docx T:\vaccine\documents\templates\lab_assay_memos\ADCC-Luc_Memo_PT_Template_2022-12-21.docx

These files reflects the above HVTN templates (and additional feedback Shannon had with lab in using % specific killing instead of % loss luciferase): inst/templates/methods-adcc/adcc-lab-methods.Rmd inst/templates/methods-adcc/adcc-biological-endpoints.Rmd inst/templates/methods-adcc/adcc-statistical-methods.Rmd inst/templates/bibliography.bib

Other files are modified to allow loading in of report_type = "adcc": R/use_visc_report.R man/use_visc_methods.Rd man/use_visc_report.Rd

I have loaded in this branch, generated the report with use_visc_report(report_type = "adcc") and knit the file and it knits as expected. See attached PDF. TEST_adcc.pdf

It should be ready for merge!

slager commented 3 weeks ago

Looks great! Knits cleanly on CI! Just 1 minor comment about a reference.