Thanks for this great start @valduran18! some general thoughts:
there is a mix of camel case vs period.separated, and I am under the impression that team prefers to use snake_case to better align with tidyverse usage, reference: https://style.tidyverse.org/syntax.html
how should we handle data object syntax? can this function handle both "Lusso847_nab" and "nab" (auto populating the package name)? will we need to compare data objects not in a VISC data package?
for the stash activity, can we name this so as not to interfere with existing stash? do we pop this stash so as not to introduce a change to the user system?
what is the benefit of using diffdf vs dplyr::all_equal or testthat::expect_equal? is this documented well?
I have posted some suggested updates for documentation/testing purposes to move the roxygen2 content along
Thanks for this great start @valduran18! some general thoughts:
I have posted some suggested updates for documentation/testing purposes to move the roxygen2 content along