FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC
Other
6 stars 2 forks source link

Update git_obj_compare_fun.R #112

Closed valduran18 closed 2 months ago

valduran18 commented 1 year ago

added an internal use function obj_compare that updates the output of diffdf, giving the user the option of either outputting the default settings, or only the warning message. If no differences are found, a character string message is returned instead of the default list. obj_compare is then used in git_object_compare

valduran18 commented 1 year ago

one thing to note is that this function runs much faster on server:

image

vs

while running this code under the profvis package, it looks like the git2r function odb_blobs() is taking up the most time

image

valduran18 commented 1 year ago

odb_blobs() on my local RStudio took ~30 min to run image

valduran18 commented 1 year ago

odb_blobs() on my local RStudio took ~30 min to run image

one possible solution is to change odb_blobs() to system2("git" ,"ls-files '*.rda'" , stdout = TRUE)

slager commented 3 months ago

Workflow:

@valduran18

If we want to include these changes in develop, we should: 1) merge this PR into git_object_compare, and then 2) merge #149 into develop