search

FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC
Other
6 stars 2 forks source link

New FH logo for Word template #117

Closed kelliemac closed 1 year ago

kelliemac commented 1 year ago

I previously updated the Fred Hutch logo for the VISC PDF template, and am now adding it for the Word template as well. I tested with a report on my end and all seems good to go! The only change was swapping the image in the word template header, nothing else.

mariev commented 1 year ago

@kelliemac do we know why the ci checks are failing? for some reason the logs aren't showing for me 😬

kelliemac commented 1 year ago

@mariev here is the error I see on the macOS check (for example):

Warning: r-lib/actions/setup-r@v1 is deprecated. Please update your workflow to use the 'v2' version. Also look at the examples at https://github.com/r-lib/actions/tree/v2/examples because '@v2' workflows are much simpler than 'v1' workflows. /usr/local/bin/brew install qpdf pkgconfig checkbashisms Error: Failed to get R 4.3.0: Failed to get R 4.3.0: Failed to download version 4.3.0: Error: Unexpected HTTP response: 404

I think your PR from today addresses this issue with the CI, so let's get that one approved and merged and see if that fixes the issue here too! (I think it will.)

kelliemac commented 1 year ago

@mariev done! checks are passing now.