FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC
Other
4 stars 2 forks source link

Update R package loading #154

Closed kelliemac closed 2 weeks ago

kelliemac commented 1 month ago

Adds missing packages, and updates guidance for data package loading

addressing https://github.com/FredHutch/VISCtemplates/issues/106 and https://github.com/FredHutch/VISCtemplates/issues/145

slager commented 2 weeks ago

replaced uses of 'here' with 'rprojroot' in #168. See:

https://github.com/r-lib/here/blob/4cb761fc9048c39aacfd14edb34b646380504afa/R/here.R#L8-L11

slager commented 2 weeks ago

Sorry for cluttering up your PR with all these commits! Adding 'remotes' to Suggests fixed the install problems on CI and now this PR has the same (desired) errors and warnings as develop. Reverting https://github.com/FredHutch/VISCtemplates/pull/154/commits/0e82a232953b917ee182ee97fb8039836b1af52e, https://github.com/FredHutch/VISCtemplates/pull/154/commits/1dea572135b8bba1da4cbf3ebbc539cb1f88e104, and https://github.com/FredHutch/VISCtemplates/pull/154/commits/71143e0ff34d964817ab8f1c1c91cefe81bec4a2 now.