search

FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC
Other
4 stars 2 forks source link

Fix latex template issue with etex and \reserveinserts #160

Closed kelliemac closed 1 month ago

kelliemac commented 1 month ago

@lemireg and I have both run into issues with the etex package and its \reserveinserts command used in template.tex causing reports to fail to compile. The etex package is apparently no longer needed (recent version of latex incorporate most of its functionality), so this hotfix comments out the relevant lines in template.tex and resolves the issue (it has been tested by me, @lemireg, and @mayerbry on our respective systems).

lemireg commented 1 month ago

@lemireg and I have both run into issues with the etex package and its \reserveinserts command used in template.tex causing reports to fail to compile. The etex package is apparently no longer needed (recent version of latex incorporate most of its functionality), so this hotfix comments out the relevant lines in template.tex and resolves the issue (it has been tested by me, @lemireg, and @mayerbry on our respective systems).

Out of curiosity @kelliemac , is this fix unrelated to pull 159 ? I didn't think it was the same issue but you mention in this description that you've come across this specific issue too. Thank you so much for this patch!

lemireg commented 1 month ago

Maybe one more thought on this... if we're commenting it out, should we just delete these two lines? git diff will be able to show the difference between this version and the last so perhaps unnecessary to leave dead code @kelliemac

kelliemac commented 1 month ago

@lemireg and I have both run into issues with the etex package and its \reserveinserts command used in template.tex causing reports to fail to compile. The etex package is apparently no longer needed (recent version of latex incorporate most of its functionality), so this hotfix comments out the relevant lines in template.tex and resolves the issue (it has been tested by me, @lemireg, and @mayerbry on our respective systems).

Out of curiosity @kelliemac , is this fix unrelated to pull 159 ? I didn't think it was the same issue but you mention in this description that you've come across this specific issue too. Thank you so much for this patch!

Yes, they're unrelated as far as I can tell.

kelliemac commented 1 month ago

@mayerbry do you have an opinion on commenting out the code vs. deleting the lines? there were already a few other lines of code commented out in template.tex which is why I wasn't too worried about it. at some point we should probably clean up all of those (I could do that now if we want)

kelliemac commented 1 month ago

Opened a separate issue (https://github.com/FredHutch/VISCtemplates/issues/161) for spring cleaning of the template.tex file including deleting all commented-out code. Will get to this later!

slager commented 4 weeks ago

+1

I hadn't encountered the \reserveinserts problem myself before, but I just had it happen building a QC report on statsrv (R 4.0.4 on Linux). I installed the newest version of VISCtemplates on main and it was resolved!