FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC
Other
6 stars 2 forks source link

Update authors in DESCRIPTION #190

Closed kelliemac closed 1 month ago

kelliemac commented 1 month ago

Addresses https://github.com/FredHutch/VISCtemplates/issues/180

@slager I have listed you as the current maintainer since you have been the most active recently in fixing bugs (thank you!!!) Let me know if you don't want to do this though - we can easily switch it to me or Bryan.

If anyone has other ideas of people who should be includes in the authors list, as either full authors or contributors, just say so. For reference here is a guide to how the author roles work: https://r-pkgs.org/description.html#sec-description-authors-at-r

slager commented 1 month ago

I'd be happy to keep regularly contributing as an author on bugfixes/etc, but I'm less comfortable being the official maintainer. I feel like it could be good to keep it officially maintained by someone who's main work/expertise is closer to the PT report workflow.

kelliemac commented 1 month ago

Ok! Totally get that @slager. We can have multiple maintainers, too. What if I give Bryan, me, and you all the "cre" designation, just to denote that we're the ones who are actively working on it in any capacity?

slager commented 1 month ago

That setup sounds fine to me. It's possible that R CMD check might complain about multiple maintainers.

The mandatory ‘Maintainer’ field should give a single name followed by a valid (RFC 2822) email address in angle brackets

kelliemac commented 1 month ago

ok, in that case I'll just put myself as the maintainer for now since I don't mind being the person who people reach out to

kelliemac commented 1 month ago

@mayerbry ok by you?