Remove dependency on full tidyverse - Githubissues

FredHutch / VISCtemplates

Tools for writing reproducible reports at VISC

Other

6 stars 2 forks source link

Remove dependency on full tidyverse #213

Closed slager closed 1 month ago

slager commented 1 month ago

Removing tidyverse from dependencies per best practices.

From: https://cran.r-project.org/web/packages/tidyverse/vignettes/paper.html

The tidyverse package is designed with an eye for teaching: install.packages("tidyverse") gets you a “batteries-included” set of 87 packages (at time of writing). This large set of dependencies means that it is not appropriate to use the tidyverse package within another package; instead, we recommend that package authors import only the specific packages that they use.

slager commented 1 month ago

With this PR:

template reports knit successfully without tidyverse, using only dplyr and ggplot2. This is visible in the Reproducibility tables in the test knit report snapshots for the final commit of this PR.

Before this makes its way into main

main is used to install dependencies (tidyverse) on the statsrv runner. dplyr and ggplot2 are included in tidyverse, so CI still works, as before, and like in 9ade5b7.

After this makes its way into main

main is used to install dependencies (no tidyverse, install dplyr and ggplot2 instead) on the statsrv runner, so it will still work, as in ad4b693. ad4b693 was a test for what will happen once this makes it way into main, showing successful CI install and tests without tidyverse when specifying the statsrv dependencies using this PR branch. With that test out of the way, I reverted the last two commits