Closed kweav closed 6 months ago
Thanks for the feedback -- I think I added responses to everything.
I've made several additions and edits to the code in order to incorporate most of this feedback. I've also verified that the code runs without error. Could we review these changes, merge this pull request, and open another for next steps?
This is passing checks and although we need to do some more iterative work on it, I think this is good enough for us to merge and put this behind us. I will file issues on what we need to iteratively work on from here.
Description
This pull request is for issue #3, functionalizing the steps of QC.
Type of change
getting_started.Rmd
vignette of loading data and running qc need fleshed out further.How Has This Been Tested?
The
run_qc()
function was added to thegetting_started.Rmd
vignette and ran without error. The filter was saved in and accessible from thegimap_dataset
variable.Checklist:
While I have performed a self-review of my code, and commented it, more comments and additions to the documentation are necessary. Tests are also necessary