FredHutch / gimap

Genetic Interaction MAPping for dual target CRISPR screens
https://fredhutch.github.io/gimap/
0 stars 0 forks source link

Quality Control -- Report Making Function #16

Closed kweav closed 6 months ago

kweav commented 7 months ago

Description

This pull request is for issue #3, functionalizing the steps of QC.

Type of change

How Has This Been Tested?

The run_qc() function was added to the getting_started.Rmd vignette and ran without error. The filter was saved in and accessible from the gimap_dataset variable.

Checklist:

While I have performed a self-review of my code, and commented it, more comments and additions to the documentation are necessary. Tests are also necessary

kweav commented 7 months ago

Thanks for the feedback -- I think I added responses to everything.

kweav commented 7 months ago

I've made several additions and edits to the code in order to incorporate most of this feedback. I've also verified that the code runs without error. Could we review these changes, merge this pull request, and open another for next steps?

cansavvy commented 6 months ago

This is passing checks and although we need to do some more iterative work on it, I think this is good enough for us to merge and put this behind us. I will file issues on what we need to iteratively work on from here.