cansavvy
commented
7 months ago
# Description
This is building on the excellent work that @kweav started over on #16 Here I'm working on simplifying that code so that when the Berger Lab is in the maintenance phase of this project they will be able to find bugs and squash them as needed.
## Type of change
What I've done is try to simplify the code. Now this is having the gimap_dataset sent directly to the Rmd report for processing.
The qc plot functions are almost completely unchanged. I'm just changing how the handling of the data is working so that we have as few objects around as possible to troubleshoot.
- [x] This change requires a documentation update
# How Has This Been Tested?
I ran this locally and it worked -- what I need @kweav to do is to make sure the report still has all the same components she originally intended.
# Checklist:
- [x] My code follows the style guidelines of this project -- I ran it through styler package.
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules