:warning: This is a stacked PR based on #35 :warning: (edit: but now that #35 is merged, I've changed the base to main)
This PR adds in a parameter/functionality to select columns for the zerocount filter. By default, the filter will select all data columns. However, it provides the user with the ability to tweak which columns are used.
I've notated in the code for both this function (and the plasmid filter function) that we could use a test in case the user supplies something to check that the user supplied target columns following the conventions we want: e.g., R vector (the c() thing -- edit(based on code review for #35, not sure it has to be the c() thing, just in some way a collection of integers like 1:2. Do we want them to be consecutive numbers?)) and are integers greater than or equal to 1 and less than or equal to the number of columns. @howardbaek can you add those or check what I add if you prefer I do the adding.
Next PR will fill in the 3rd filter/target col selection parameter discussed in PR #35.
:warning: This is a stacked PR based on #35 :warning: (edit: but now that #35 is merged, I've changed the base to main)
This PR adds in a parameter/functionality to select columns for the zerocount filter. By default, the filter will select all data columns. However, it provides the user with the ability to tweak which columns are used.
I've notated in the code for both this function (and the plasmid filter function) that we could use a test in case the user supplies something to check that the user supplied target columns following the conventions we want: e.g., R vector (the
c()thing -- edit(based on code review for #35, not sure it has to be the c() thing, just in some way a collection of integers like1:2. Do we want them to be consecutive numbers?)) and are integers greater than or equal to 1 and less than or equal to the number of columns. @howardbaek can you add those or check what I add if you prefer I do the adding.Next PR will fill in the 3rd filter/target col selection parameter discussed in PR #35.