search

FredHutch / shiny-cromwell

Shiny app for interacting with the Fred Hutch instances of Cromwell. Contact Taylor Firman.
https://proof.fredhutch.org
MIT License
3 stars 3 forks source link

Validate multiple JSON files #11

Open sckott opened 9 months ago

sckott commented 9 months ago

(via a call with Sita today)

In the validate page only one JSON file can be uploaded. It would be nice to be able to validate more than one.

In the validate code https://github.com/FredHutch/shiny-cromwell/blob/main/app/server.R#L52-L57 we could make a change, depending on how the Cromwell API route behaves within the cromwellValidate function. I can't quite tell from the API docs if multiple JSON files are accepted or not. If not, we could run cromwellValidate in a loop/lapply for each JSON file

cc @sitapriyamoorthi

sitapriyamoorthi commented 9 months ago

@vortexing any insight into this?

sitapriyamoorthi commented 9 months ago

This could also be important when we want to validate all JSON files especially as the community begins to build out their own WDLs

sitapriyamoorthi commented 9 months ago

We also want to reconsider the verbosity of errors that is thrown out when a workflow does not validate!

vortexing commented 9 months ago

These are features (weaknesses) of womtool itself. These are all something that the tool being run and it's API limit us to. If we allow additional functionality, we'll have to build it. This one is a larger lift to fix.

vortexing commented 8 months ago

If more than 1 input json is provided, the shiny app will have to take them, concatenate them, then pass that consolidated json to womtool to validate. If you all want to do this, great, but I am not going to list it as a priority today.

tefirman commented 2 months ago

I echo @vortexing's sentiment above 100%. Would be nice to have, but not a priority for v1.X. That being said, I think it's very important for v2.0 since we will already be reorganizing things at that point. Adding to the v2.0 milestone and tagging as low priority for now.