FredHutch / shiny-cromwell

Shiny app for interacting with the Fred Hutch instances of Cromwell. Contact Taylor Firman.
https://proof.fredhutch.org
MIT License
2 stars 3 forks source link

Failures in app don't reflect failures in nested scatters #110

Open vortexing opened 2 months ago

vortexing commented 2 months ago

So when a workflow has nested scatters, the failures of tasks in the nested scatters DO show up in the failures table on the app, however the summary of the failed jobs icon does not reflect them!

The icon shows 1 failed job:

Screenshot 2024-06-21 at 8 41 18 AM

But actually there were actually 6 and 1 was a re-tried failure (for 7 total failed jobs).

Screenshot 2024-06-21 at 8 44 23 AM

I would've expected the icon to show 6 failed calls (and not reflect the re-try as a separate failure but that would be better than what it's doing now).

tefirman commented 1 month ago

@vortexing -- Can you point us to the WDL that was used to produce this? Just want to try to recreate this.