search

FredHutch / shiny-cromwell

Shiny app for interacting with the Fred Hutch instances of Cromwell. Contact Taylor Firman.
https://proof.fredhutch.org
MIT License
3 stars 3 forks source link

Possibly pin/freeze package versions? #39

Open sckott opened 8 months ago

sckott commented 8 months ago

... so app doesn't break due to dependency package version updates

It's not totally clear how to do this, but most likely renv

sckott commented 7 months ago

I think this is quite feasible with renv. They even have a vignette on using it with docker.

Work on this in a branch renv - still not working yet - having problems with dependencies - first thing you hit after running built image is:

Warning: Error in library: there is no package called ‘shinydashboard’
  64: <Anonymous>
  63: stop
  62: library
   1: runApp
sckott commented 7 months ago

command to build and run:

docker build --platform linux/amd64 -t shiny-cromwell:renv .
docker run -p 3838:3838 shiny-cromwell:renv
sckott commented 7 months ago

@dtenenba thinking about moving to a setup where we're pinning package versions so that we aren't surprised by any package updates. here's the dockerfile with changes. it's not working quite yet, see above. Any concerns with this setup?

tefirman commented 2 months ago

@sckott -- How much of a lift would this be? Feels like an important step, just deciding whether it can be brought into v1.X..

sckott commented 2 months ago

I think we can skip this for the Shiny app since we're moving away from it to JS land. In JS it's easy to pin packages, so we'll be all set there.