Update to use HtmlCompat and fix error when no icon url exists in feed item

FredJul / Flym

Flym News Reader is a light Android feed reader (RSS/Atom)

Other

953 stars 403 forks source link

Update to use HtmlCompat and fix error when no icon url exists in feed item #687

Closed fireph closed 4 years ago

fireph commented 4 years ago

Depends on https://github.com/FredJul/Flym/pull/686

FredJul commented 4 years ago

Hi @fireph !

Again, I believe you did a great job. I have merged it because it seems to work just fine. However I was a bit surprised with one thing: I believed the setTheme needed to be called before super.onCreate(), which is not the case anymore with the doAsync, but again it seems to just work. Do you have more info about that? I'm surprised a setTheme needs to be done in a separate thread

fireph commented 4 years ago

@FredJul The setTheme isn't the issue, but rather the shared preferences access that needs to be on a separate thread. I tried putting it all in a doAsync{} and then having the setTheme in a uiThread{}, but that didn't work. I might have to look into this a bit more to 100% make sure this is the right approach for putting the shared preferences access on a separate thread.