search

FredJul / Flym

Flym News Reader is a light Android feed reader (RSS/Atom)
Other
951 stars 405 forks source link

For #689: Improve letter selection for feed icon #694

Closed dglttr closed 4 years ago

dglttr commented 4 years ago

By splitting the feed name along the blank and - characters and choosing the first character of each word. When no delimiter is found, simply chooses the first character in the word (this is the same behavior as apps like Outlook for Android or Signal use).

For details see the issue #689.

(Re-opened this PR to have a clean commit history.)

FredJul commented 4 years ago

While I agree with the principle, I believe the current state has some drawbacks.

For instance, I have LeMonde's "Politique : Toute l'actualité" feed which will become "P:". So I would suggest to add several characters like ":", "|" or "&" to split the words as well.

"Science et Avenir" will become "SE" and in that case I prefer "SA" or even the original "SC". But I guess I can accept that if it globally improves the app.

dglttr commented 4 years ago

Pushed a commit to include the delimiters you listed and work correctly when multiple delimiters are found.

As a result, see this screenshot:

Specifically for feeds like "Science et Avenir", my suggestion for users would be renaming the feed, replacing "et" with & (as I did in the screenshot).

FredJul commented 4 years ago

I guess it's OK now, thank you for your help!