search

FredKSchott / create-snowpack-app

The all-in-one app template for Snowpack. [moved]
https://www.snowpack.dev
Other
727 stars 96 forks source link

Update import meta typing to include env #114

Closed stramel closed 4 years ago

stramel commented 4 years ago

Looks like we forgot to add the env key to the importMeta type definition.

Brought up in https://github.com/pikapkg/snowpack/pull/394#issuecomment-639154557

FredKSchott commented 4 years ago

makes sense! I'm going to look into a DefinitelyTyped @types/snowpack declaration as well

stramel commented 4 years ago

I think that would be a good plan so users not using csa, don't have to manually create these typings.

FredKSchott commented 4 years ago

Added a new PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45315