FredKSchott / rollup-plugin-polyfill-node

A modern Node.js polyfill for your Rollup bundle.
Other
179 stars 57 forks source link

feat(util): add `callbackify` & `promisify` #65

Closed MichaelDeBoey closed 1 year ago

MichaelDeBoey commented 1 year ago

Just like @IvanKushchenko did in https://github.com/ionic-team/rollup-plugin-node-polyfills/pull/40 & @abhishek-mittal did in https://github.com/ionic-team/rollup-plugin-node-polyfills/pull/45

@giuseppeg suggested in https://github.com/remorses/esbuild-plugins/pull/19#discussion_r1048398962 to use https://github.com/browserify/node-util directly, but we can do that in a follow-up PR if that's OK for @FredKSchott


Closes https://github.com/ionic-team/rollup-plugin-node-polyfills/issues/38

MichaelDeBoey commented 1 year ago

@FredKSchott Do I need to do anything else to get this one merged?

FredKSchott commented 1 year ago

LGTM!