[BUG] Imports break when loaded in an external module and the source.

[anisebamford]

Bug Report Quick Checklist

• [x] I am on the latest version of Snowpack & all plugins.
• [x] I use package manager npm (Fill in: npm, yarn, pnpm, etc).
• [x] I run Snowpack on OS Linux in docker (Fill in: Windows, Mac, Linux, etc).
• [x] I run Snowpack on Node.js v12+

Describe the bug

When a React component is imported by an external cjs library and by the es6 source, the import breaks in the external library.

To Reproduce

1: Download the demo https://github.com/bumpusfrancus/snowpack-bug-demo 2: Start the demo with docker-compose up -d. a: The demo's ip address can be obtained with docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' $(docker-compose ps | grep "node" | awk '{ print $1}') 3: Go to the IP_ADDRESS:3000/index. The error will appear in the browser console. 4: Go to the IP_ADDRESS:3000/other. The component will be rendered.

Expected behavior

The component should render the same way in both cases.

[anisebamford]

My investigation found that when the third party module is packed, it is placed in an object under a "default" key. The external import then creates another object with a default key holding that object, making the correct path to the component IMPORT_NAME.default.default, but the code is trying to load the component from IMPORT_NAME.default.

[anisebamford]

If you do not use docker, the server is in server/index.js. It uses an absolute path in express static, so that path will need to be updated.

[anisebamford]

This is still an issue in version 3.8.6