FredReinink / Wellness-app

Health and fitness tracker web application
3 stars 3 forks source link

Fitness Tracker #9

Closed panktiHT closed 5 years ago

panktiHT commented 5 years ago

Fitness Tracking

Action Item 1: -Tables for followedexercises and weightlifting tracker can be changed such that it is: username | userExercise a user can add multiple exercise and it will simply just create more rows. The way you have set up creates a lot of null values and you also get limitations

Action Item 2: -For column with the title 'num of exercise' - not sure what the purpose is but if it is counting total number of exercises performed then it's a derived attribute . Thus, does not get shown in RM or in the SQL table. ONLY when you display this information to the user you can just SELECT* and count number of row that belong to that person for that date if you follow my proposed table to count total number of exercise.

Action Item 3: same with weightliftingtracker table. pls modify the SQL table design to avoid having it mostly null

Action Item 4: I do not understand the purpose of having 'fitnesstracker' table in MySQL, because information in here is redundant and can come from weightlifting tracker and cardio tracker. The way it has been set up shows that weights can be tracked independently from cardio. So dates for both can vary independently. Don't quite see a purpose of ONLY having dates in fitnesstracker table.

Action Item 5:

Similarly with cardio information

Action Item 6: finally, in the user interface you are ONLY asking user to enter the information. NEED to display history of this to the user so they can see things they have done over the time (whether that is in form of a table or graph - just transfer over information from mySQL to fitnessTrack.php)

Please let me know if any of the requested action items are not clear. Thanks!

FredReinink commented 5 years ago

1) This is true although I don't really see enough downsides that would warrant changing this. 2) Good point, I'll work on changing this. 3) Same as (1) 4) Good point. fitnessTracker was used when we tracked exercise hours and sleep hours but is not needed now. I'll work on fixing this. 5)I may be misunderstanding you but the user enters the reps/weight on the Fitness Tracker page. 6)I decided to have one category that encompasses all cardio since the distinction between types of cardio isn't extremely relevant. Is cycling really that far removed from running that you would want to treat them distinctly? 6)User data history is displayed back in the progression charts on dashboard.

FredReinink commented 5 years ago

(4) Resolved in eb86865f1599d83018236a43aac83d4ff9c3af31.

panktiHT commented 5 years ago

(1) + (3) --> already discussed. Change if required (2) --> Great (5) --> interesting, i clicked all the buttons, i couldn't find a page where i enter reps/weight information. Where is it then? (6) --> I agree with the wise author (I certain don't actually agree with the supporting facts but for the project it's fine) (7) --> clarify, so you will be adding history to display progress? I mean details about reps/weight, cardio/time/type of cardio (if you change your mind about 6)

FredReinink commented 5 years ago

(4) Fixed in 50f89f6757df73adfcb1e9edbc312119e63f1ce2.

FredReinink commented 5 years ago

(5) On the Fitness Tracker page. (7) The charts already display progress regarding reps/weight and cardio.

FredReinink commented 5 years ago

Regarding (7). I've modified the charts so it's hopefully a little more clear what they're displaying.

panktiHT commented 5 years ago

All looks good and works.