search

FredTingaud / quick-bench-front-end

Front end side of quick-bench
BSD 2-Clause "Simplified" License
142 stars 11 forks source link

Support setting the x86 disassembler style #23

Closed MattPD closed 10 months ago

MattPD commented 5 years ago

Essentially: Expose the UI support for the following feature in perf: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f69b64f73e1d7f47a9205c1cd46e0e1c3c65e1cd

The underlying support exists in objdump (which is used by perf itself): https://lkml.org/lkml/2011/9/29/482

For example, perf report -M intel selects the Intel syntax (instead of the default AT&T syntax).

hawkinsw commented 2 years ago

@FredTingaud I am working on this as we speak! I hope to have a patch for it by the end of the weekend!

FredTingaud commented 2 years ago

Nice! It's a pretty complex dev as it will require to change the whole chain, from the front-end to the containers. Don't hesitate to post if you are stuck and improving the documentation could help.

hawkinsw commented 2 years ago

I am just doing some testing now. I think that I got it working!

lhmouse commented 11 months ago

And Intel syntax shall be the default. That's the only standard and documented syntax.

MattPD commented 10 months ago

Closing, as setting the format seems to work (already fixed by #63 and related changes in the backend & docker projects). The default may be a good idea, too, although that may warrant a distinct, new issue.

lhmouse commented 10 months ago

Closing, as setting the format seems to work (already fixed by #63 and related changes in the backend & docker projects). The default may be a good idea, too, although that may warrant a distinct, new issue.

I have opened #84 for that.