search

FredTingaud / quick-bench-front-end

Front end side of quick-bench
BSD 2-Clause "Simplified" License
141 stars 11 forks source link

Add support for multiple annotated ASM formats #63

Closed hawkinsw closed 2 years ago

hawkinsw commented 2 years ago

Overload the isAnnotated flag to direct the backend to generate annotated disassembly in either AT&T or Intel syntax. Default to AT&T.

https://github.com/FredTingaud/quick-bench-front-end/issues/23

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

hawkinsw commented 2 years ago

I am going to close this PR in favor of a new one. It will simplify the workflow as I debug -- you won't get spammed with a bunch of notifications!

hawkinsw commented 1 year ago

Great UX idea! I will definitely do that!!

Also, I will add those tests. Thanks for the feedback! An updated patch may be a few days away -- end of the semester means lots of grading!

Thanks again for all the feedback!

On Sat, Apr 16, 2022 at 1:28 PM Fred Tingaud @.***> wrote:

@.**** requested changes on this pull request.

I realize the project is not well configured and tests are not run automatically on pull requests. I think I fixed that at head. There should be at least one test failing with this change because there are snapshot tests. You can run them by running yarn test in the folder quick-bench.

Also, a small UX nitpick, but I'm not a fan of having both the dropdown and the checkbox, because unchecking the checkbox makes the dropdown useless. I think I would prefer completely removing the checkbox (but keeping the label "Record disassembly") and having the dropdown choice between (No, AT&T, Intel).

— Reply to this email directly, view it on GitHub https://github.com/FredTingaud/quick-bench-front-end/pull/63#pullrequestreview-943873820, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCP2CVZBCDOZCZ3BFEA37DVFL2CTANCNFSM5TEEZLEA . You are receiving this because you authored the thread.Message ID: @.***>