search

FreddieHong19 / Open5x

This is a Github repository for 5-axis 3D printing
MIT License
954 stars 149 forks source link

Grasshopper Files CleanUp & Organisation #14

Open leobroom opened 2 years ago

leobroom commented 2 years ago

Hey Freddie, first of all: Great work and congratulation for this astonishing project! I love it!

I looked inside the Grasshopper definitions and have to say that a part of the performance issues may be caused by the inefficient script, but it is difficult to read and understand the dependies. I know that there is a ton of work in these scripts involved, so please do not feel ofended.

This is how it actual looks like: GH_actual

It should look more like this: GH_cleanup

I propose:

  1. Organise the script, and straighten wires without changing the script, to make the dependencies more visible.
  2. Reduce Components, where possible.
  3. Writing C# Components, especially with basic mathematical operations
  4. Document more the script.

I would like to contribute and have some experience in additive manufacturing and writing slicers in grasshopper.

Now you wrote that the definition is going through a series of iterations and if i or someone else would now start to organise it - manual merge problems could occur. Does it make sense to reorganise and cleanup the script?

What is your opinion about that Issue?

Greetings, Leon

FreddieHong19 commented 2 years ago

Hi Leon,

Thank you so much for your insight into the project. Your proposed organization of the script indeed looks much clearer! I have been working on this definition for a while, iterating after each test print, and over time, the definition grew messier. I am going through the last phase of my PhD and have no spare time to clean up the documentation (as you can tell!). After the submission, I plan to revisit the documentation and add clarity for more audiences. I am also very open to inviting more contributors familiar with 3D printing with Grasshopper.

Best, Freddie

leobroom commented 2 years ago

Hey Freddie, thank you for your fast response. All the best for your PhD thesis! Maybe i was not clear with my message, sorry. I could start with the organisation/ documenting process - when I know that you are okay with it and from your point in would make sense. So if you need help with that - just write me.

FreddieHong19 commented 2 years ago

Hi Leon, I am expecting to upload the new version of Grasshopper script sometime in late November. Perhaps we can catchup again then. Thank you!