nus-se-script
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Add Command: Instruction does not allow for dashes
I believe that titles should be allowed to accept hyphen-dashes, espcially since there are words that exist in the dictionary that have dashes.
Not frequent to have such words but may still confuse the user especially since the error message claims that a word/sentence was not given for the title when orange-juice is considered a word
[original: nus-cs2103-AY2223S2/pe-interim#2765] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
It is a feature flaw as we only take in alphanumeric and space when parsing user inputs for descriptions/titles/etc.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: I do not agree that this is considered a duplicate bug.
While both bugs have the same issues of not allowing for dashes, they stem from 2 different fields/classes and requires changes to 2 different parts of the code.
More specifically, they would have to fix the VALIDATION_REGEX variable in both Step.java and Title.java
According to the definition, they are only considered duplicate bugs if fixing one bug automatically fixes another. But fixing the parser for the title to allow for dashes does not fix the parser for the steps to allow for dashes.
I believe that instructions should be allowed to accept hyphen/dashes, espcially since there are words that exist in the dictionary that have dashes.
For instructions, words such as rinse-dry may be used but an error would be thrown instead.