soc-se-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Editing prices
editing price of food silently rounds off to 2dp without telling user, I think there should at least give a warning that it has been rounded off.
[original: nus-cs2103-AY2223S2/pe-interim#1969] [original labels: severity.VeryLow type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
We are trying to mimic real world environments, so we are working with 2dp for prices. In the real world, prices that are not 2dp do not exist.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: I don't think this bug is a duplicate
The original bug is more of claiming that there should be a warning raised so that the user will not assume that it'll be 2dp and mistakenly keys in a 3dp price and not realizing that it has been silently rounded off by the app without warning the user, which might lead to potential confusion for the user.
This bug claiming that there should be a sub-feature that allows for the chaning of decimal places for prices if the user wants to record prices in different decimal places. However, even if this feature is implmeneted, it does not solve the original bug because there can still be a scenario where the user sets the price decimal placing to 3dp and inputs a 4dp price. Then if the original bug is not solved, the app will still silently round off the price from 4dp to 3dp without warning the user, still potentially confusing the user in the future.
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I believe that it should not be rejected as it is still a valid point, with the same reasoning given in my other response: It it incorrect to say that there are no cases where more than 2dp is used for prices. There are some examples where more than 2dp of prices are used is in oil/petrol stations and especially in the fintech industry involving shares. While these are definitely not in the scope of your project, the point I am trying to put across is that while it is ok to restrict the pricing to just 2dp, in the **rare situation (hence VeryLow severity)** where the user wants to use >2dp on their pricing, the app should allow for the user to change the precision instead of silently round it off without telling the user. This might cause confusion down the line when they did not realize that the pricing has been rounded off and result in slightly incorrect pricing.
I believe that users should be able to change the precision of prices to their wishes. Currently the app fixates to only 2dp for price which limits flexibility, especially in the scenario where the user wants to count up to 3dp