FredericChow00 / pe

0 stars 0 forks source link

Editing prices #9

Open FredericChow00 opened 1 year ago

FredericChow00 commented 1 year ago

editing price of food silently rounds off to 2dp without telling user, I think there should at least give a warning that it has been rounded off.

nus-pe-bot commented 1 year ago

Team's Response

We are trying to mimic real world environments, so we are working with 2dp for prices. In the real world, prices that are not 2dp do not exist.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Developers claimed that "In the real world, prices that are not 2dp do not exist". This is incorrect.

Some examples where more than 2dp of prices are used is in oil/petrol stations and especially in the fintech industry involving shares of stocks.

While these are definitely not in the scope of your project, the point I am trying to put across is that while it is ok to restrict the pricing to just 2dp, in the rare situation (hence VeryLow severity) where the user wants to use >2dp on their pricing, the app should not silently round it off without telling the user. This might cause confusion down the line when they did not realize that the pricing has been rounded off and result in slightly incorrect pricing.

Instead, I was suggesting that it should at least give a warning but let this still be executed.