search

FredericHeem / redux-act-async

Reduce boilerplate for redux async actions and reducers
Apache License 2.0
125 stars 22 forks source link

chore(lodash): remove lodash.defaultdeep #22

Closed mastilver closed 7 years ago

mastilver commented 7 years ago

switch from lodash.defaultdeep to object-assign

I'm using this package on my project (Great one btw :smile: )

I've notice one of its dependency (lodash.defaultdeep) is using a lot of space, so to reduce the bundle size I replaced it with a lighter package: https://github.com/sindresorhus/object-assign It follow Object.assign specs so it can be replace once IE11 is out of the market: http://kangax.github.io/compat-table/es6/#test-Object_static_methods_Object.assign

codecov-io commented 7 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          36     37    +1     
  Branches        5      6    +1     
=====================================
+ Hits           36     37    +1
Impacted Files Coverage Δ
src/createActionAsync.js 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9a177f...b5f211d. Read the comment docs.

codecov-io commented 7 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          36     37    +1     
  Branches        5      6    +1     
=====================================
+ Hits           36     37    +1
Impacted Files Coverage Δ
src/createActionAsync.js 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9a177f...b5f211d. Read the comment docs.

FredericHeem commented 7 years ago

How fat is defaultdeep compared to object-assign?

FredericHeem commented 7 years ago

According to https://github.com/FredericHeem/starhackit/blob/master/client/README.md, it is a massive 58kB.

mastilver commented 7 years ago

@FredericHeem I had the same kind of numbers! Thank you for merging :+1: