search

FredericJacobs / OpenSSL-Pod

Unmaintained - please fork. Email me to take over the CocoaPod
74 stars 112 forks source link

Update OpenSSL to 1.0.1j (spec version 1.0.110) #7

Closed phatblat closed 10 years ago

phatblat commented 10 years ago

Added a new spec version for 1.0.1j and also split out the build script into a separate prepare_command.sh file for easier testing and a more readable spec.

Note that I couldn't get this or any previous version of the spec to lint cleanly. It looks like a CocoaPods limitation on specs with tarball style source entries. However, I found a workaround:

$ wget -O file.tgz https://www.openssl.org/source/openssl-1.0.1j.tar.gz
$ pod lib lint

 -> OpenSSL (1.0.110)

OpenSSL passed validation.

With the file.tgz file in place, this spec lints clean on 0.33.1 and 0.34.4.

FredericJacobs commented 10 years ago

Sweet, looks good to me. Will review it and push it straight after. thanks you!

FredericJacobs commented 10 years ago

Doesn't appear to build right for me.

[!] /bin/bash
set -e
sh prepare_command.sh

sh: prepare_command.sh: No such file or directory
FredericJacobs commented 10 years ago

The issue is that the script won't be part of the podspec repo. Sadly it can't be another file when pushing it to the podspec library.

FredericJacobs commented 10 years ago

I merged #6 that updates the version. Separating the script won't work out unfortunately.

phatblat commented 10 years ago

Ah, didn't think of that.