search

Frederick888 / external-editor-revived

External Editor Revived is a Thunderbird MailExtension which allows editing emails in programs such as Vim, Neovim, Emacs, etc.
GNU General Public License v3.0
110 stars 6 forks source link

Broken threads when replying #110

Closed nicoroeser closed 9 months ago

nicoroeser commented 1 year ago

Description

Version 91f2118192ba09135da99983f4fb5552a3e04dfe breaks threads when used for replies: (at least) headers In-Reply-To and References are missing. IIRC, this worked before (but I am not sure about in which exact version; I could try to bisect it when that becomes important).

Environment

Configuration

Logs

From the error console: composeDetails.replyTo is an empty array; I assume that is related.

Screenshots

Not needed (mail without headers, threading broken, receivers/list members annoyed :slightly_frowning_face: ).

Frederick888 commented 1 year ago

Thank you for help in testing!

Unless I am mistaken about how custom headers work, this is a bug in Thunderbird, and I've reported it to https://bugzilla.mozilla.org/show_bug.cgi?id=1824594. If it doesn't get addressed soon, I may have to disable this feature in the next release. For now I have #111.

composeDetails.replyTo is not related by the way. It controls the 'Reply-To' field which tells the recipient to which email address they should send their replies.

image

nicoroeser commented 1 year ago

Thank you for help in testing!

You’re very welcome! Thanks to you for this wonderful, time-saving extension!

Unless I am mistaken about how custom headers work, this is a bug in Thunderbird, and I've reported it to bugzilla.mozilla.org/show_bug.cgi?id=1824594.

Thank you. About saving as draft: unsure. I think it is not necessary, but my Thunderbird is configured to auto-save every few minutes, and I am not totally sure what happened.

If it doesn't get addressed soon, I may have to disable this feature in the next release. For now I have #111.

Great! (I mean the workaround, not possibly having to disable the feature.)

I have tested the current state (commit df1f8c216c356916da66cc691639b130386f1873) when replying to a message and editing it with the extension. The results were as I (and I assume, you as well) had expected:

save as draft custom headers result
not explicitly (quite sure it was not auto-saved, but not 100% sure) disabled ✔ (works)
manually, before sending disabled ✔ (works)
not explicitly (quite sure it was not auto-saved, but not 100% sure) enabled, one custom header added ❌ (fails): threading broken, custom header is present, In-Reply-To and References (and possibly others, not verified) are missing

It does not matter much for me, because I do not need custom headers at the moment. Thanks for the workaround. :smiley:

composeDetails.replyTo is not related by the way. It controls the 'Reply-To' field which tells the recipient to which email address they should send their replies.

Ah, I see. I thought this might be the case, but was not able to understand the code immediately. Thanks for clarifying! :thumbsup:

Frederick888 commented 10 months ago

Could you please check, when you do have custom headers, whether this is still an issue with TB 115?

Frederick888 commented 9 months ago

I tested it with TB 115 and I couldn't reproduce this issue any more.