Frederick888 / external-editor-revived

External Editor Revived is a Thunderbird MailExtension which allows editing emails in programs such as Vim, Neovim, Emacs, etc.
GNU General Public License v3.0
113 stars 6 forks source link

Eating "References" and "In-Reply-To" Headers since 1.0.0 #140

Closed bits-fritz closed 8 months ago

bits-fritz commented 11 months ago

Description

After upgrade to 1.0.0 "References" headers dissapear after editing with ExtEditorR.

Environment

Configuration

Editor: gVim

Command template: gvim --nofork "/path/to/temp.eml"

Steps to reproduce:

Workaround

Downgrading both: messaging host and addon at version 0.6.0 keeps headers after editing.

Frederick888 commented 11 months ago

[1] again? The fix in Thunderbird was not backported AFAIK, but I did have a workaround [2].

Sounds like you did not add any custom headers. In Error Console, did EER receive a composeDetails.customHeaders field from the host?

[1] https://github.com/Frederick888/external-editor-revived/issues/110 [2] https://github.com/Frederick888/external-editor-revived/commit/36ce2193c951950e395a29e53d4e816206aaa83f

On 8/12/23 09:20, bits-fritz wrote:

Description

After upgrade to 1.0.0 "References" headers dissapear after editing with ExtEditorR.

Environment

*

OS: Linux

*

Thunderbird version: 102.15.1

*

ExtEditorR extension version: 1.0.0

*

|external-editor-revived --version| output: |External Editor Revived native messaging host for linux (x86_64) v1.0.0|

Configuration

Editor: gVim

Command template: |gvim --nofork "/path/to/temp.eml" |

Steps to reproduce:

  • Answer any mail
  • |save|
  • go to |drafts| folder and show source code of draft (|Crtl u| in case)
  • |References| and |In-Reply-To| headers are there.
  • edit with ExtEditorR
  • |save|
  • go to |drafts| folder and show source code of draft (|Crtl u| in case)
  • |References| and |In-Reply-To| headers are gone.

    Workaround

Downgrading both: messaging host and addon at version 0.6.0 keeps headers after editing.

— Reply to this email directly, view it on GitHub https://github.com/Frederick888/external-editor-revived/issues/140, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCMP74YUI7YEWOAVBEIOKDYII6JDAVCNFSM6AAAAABALYYPWSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTCNRRHE4TGMI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Frederick Zhang

PGP: 8BFB EA5B 4C44 BFAC C8EC 5F93 1F92 8BE6 0D8B C11D

bits-fritz commented 8 months ago

Did not dig deeper, instead kept up with 0.6.0 until my other quirks with Thunderbird115 were fixed i.e. mailboxalert -> filtaquilla. So from my part this can be closed savely. Sorry for the noise.. Thank You so much for keeping this addon alive! :-)