Frederick888 / external-editor-revived

External Editor Revived is a Thunderbird MailExtension which allows editing emails in programs such as Vim, Neovim, Emacs, etc.

GNU General Public License v3.0

113 stars 6 forks source link

Neovide option uses non-existent CMD flag --nofork #143

Closed ekorchmar closed 10 months ago

ekorchmar commented 10 months ago

Description

Neovide external editor does not start with default config. --noforkshould be replaced with --no-fork. When changed manually under "Custom" list option, works as expected.

Environment

OS: Arch Linux (btw)
Thunderbird version: Thunderbird 115.6.1
ExtEditorR extension version: 1.0.0
external-editor-revived --version output: External Editor Revived native messaging host for linux (x86_64) v1.0.0

Configuration

Default with neovide option chosen.

Logs

Error is displayed by external app, no trace in logs.

Screenshots

Frederick888 commented 10 months ago

Thanks for the report! It seems that this was changed in https://github.com/neovide/neovide/commit/5743356d654dbeaf213c0da3e2988c4d89c218e1#diff-4583b895d17596f30dcbac33a7d47de9c210df2c07210bb0775b7c27097345daR55. I'll update the template in the next release.

ekorchmar commented 10 months ago

Thank you for prompt response. I've submitted a PR for convenience #144

Frederick888 commented 10 months ago

Thanks again. https://github.com/Frederick888/external-editor-revived/commit/4805a1d1e0ada1a581583be6bdd0af9e6a974107 is in the tree now.