search

Frederick888 / external-editor-revived

External Editor Revived is a Thunderbird MailExtension which allows editing emails in programs such as Vim, Neovim, Emacs, etc.
GNU General Public License v3.0
113 stars 6 forks source link

Universal external-editor-revived (for NativeMessagingHosts) #34

Closed ondohotola closed 2 years ago

ondohotola commented 2 years ago

Description

It works on both the X_86 and on the M1. As it is a pure X_83 app it'll use Rosetta. Cmd-E works as well (in favour of the Ctrl-E (on the Mac))

Is would it be possible to modify the compile process to generate a Universal app for the Mac, please?

greetings, el

Environment

Configuration

/Applications/Alpha.app/Contents/Resources/alphac

Frederick888 commented 2 years ago

A quick search led me to [1].

I only have access to an Intel MacBook. I can test a few things mentioned in [1] out when I get around it, but tbh I have no idea how these things work atm (especially in terms of whether it's easy to cross-compile and whether it's possible to do this in GitHub Actions).

Worst case we'll need to wait for Cargo to officially support this, or simply ship two binaries if GitHub offers free M1 Actions runners first.

[1] https://github.com/rust-lang/cargo/issues/8875

On 10/7/22 22:44, ondohotola wrote:

Description

It works on both the X_86 and on the M1. As it is a pure X_83 app it'll use Rosetta. Cmd-E works as well (in favour of the Ctrl-E (on the Mac))

Is would it be possible to modify the compile process to generate a Universal app for the Mac, please?

greetings, el

Environment

  • OS: Darwin XXXXXXX 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:29 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T8101 arm64
  • OS: Darwin XXXXXXX 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64
  • Thunderbird version: 91.11.0/
  • ExtEditorR extension version: 0.2.0

  • ExtEditorR host version: External Editor Revived native messaging host v0.2.0

    Configuration

/Applications/Alpha.app/Contents/Resources/alphac

— Reply to this email directly, view it on GitHub https://github.com/Frederick888/external-editor-revived/issues/34, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCMP74RVNQEV5M2G36SBYTVTLARJANCNFSM53E65CRA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Best regards, Frederick Zhang

Email: @.*** PGP: 8BFB EA5B 4C44 BFAC C8EC 5F93 1F92 8BE6 0D8B C11D

ondohotola commented 2 years ago

Frederick,

thanks.

I am an elderly Gynecologist dabbling at the most a little in Perl and LaTeX, I don't even understand most of what you are writing here :-)-O.

I would not mind either way, universal or two binaries. And I can wait :-)-O

greetings, el

On 2022-07-10 15:11 , Frederick Zhang wrote:

A quick search led me to [1].

I only have access to an Intel MacBook. I can test a few things mentioned in [1] out when I get around it, but tbh I have no idea how these things work atm (especially in terms of whether it's easy to cross-compile and whether it's possible to do this in GitHub Actions).

Worst case we'll need to wait for Cargo to officially support this, or simply ship two binaries if GitHub offers free M1 Actions runners first.

[1] https://github.com/rust-lang/cargo/issues/8875

On 10/7/22 22:44, ondohotola wrote:

Description

It works on both the X_86 and on the M1. As it is a pure X_83 app it'll use Rosetta. Cmd-E works as well (in favour of the Ctrl-E (on the Mac))

Is would it be possible to modify the compile process to generate a Universal app for the Mac, please?

greetings, el [...] -- Dr. Eberhard W. Lisse \ / Obstetrician & Gynaecologist @.** / | Telephone: +264 81 124 6733 (cell) PO Box 8421 Bachbrecht \ / If this email is signed with GPG/PGP 10007, Namibia ;____/ Sect 20 of Act No 4 of 2019 may apply

Frederick888 commented 2 years ago

Could you (or anyone watching this with an M1 machine) give the binaries from [1][2] a shot?

According to build logs they feature both x86_64 and aarch64:

$ file target/release/external-editor-revived
target/release/external-editor-revived: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
target/release/external-editor-revived (for architecture x86_64):   Mach-O 64-bit executable x86_64
target/release/external-editor-revived (for architecture arm64):    Mach-O 64-bit executable arm64

They looked ok on my Intel MacBook.

[1] https://github.com/Frederick888/external-editor-revived/actions/runs/2648189295 [2] https://github.com/Frederick888/external-editor-revived/releases/tag/untagged-ff629f64e2f3a70db82f

ondohotola commented 2 years ago

Will do this evening.

el

-- Dr. Eberhard W. Lisse \ / Obstetrician & Gynaecologist @. / | Telephone: +264 81 124 6733 (cell) PO Box 8421 Bachbrecht \ / If this email is signed with GPG/PGP 10007, Namibia ;____/ Sect 20 of Act No. 4 of 2019 may apply On 11. Jul 2022, 10:26 +0200, Frederick Zhang **@.***>, wrote:

Could you (or anyone watching this with an M1 machine) give the binaries from [1][2] a shot? According to build logs they feature both x86_64 and aarch64: $ file target/release/external-editor-revived target/release/external-editor-revived: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64] target/release/external-editor-revived (for architecture x86_64): Mach-O 64-bit executable x86_64 target/release/external-editor-revived (for architecture arm64): Mach-O 64-bit executable arm64 They looked ok on my Intel MacBook. [1] https://github.com/Frederick888/external-editor-revived/actions/runs/2648189295 [2] https://github.com/Frederick888/external-editor-revived/releases/tag/untagged-ff629f64e2f3a70db82f — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

ondohotola commented 2 years ago

Frederick,

I can also confirm, in the interim, that it works on

 Darwin XXXXXXXX 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:22
 PDT 2022; root:xnu-8020.121.3~4/RELEASE_X86_64 x86_64

 Monterey 12.4

and will check tonight on the M1 airbook.

Link [2] below results in a "404 Page not found" for me, but [1] allows the download (ZIP)

greetings, el

On 11/07/2022 11:19, Dr Eberhard W Lisse wrote:

Will do this evening.

el [...] On 11. Jul 2022, 10:26 +0200, Frederick Zhang @.***>, wrote:

Could you (or anyone watching this with an M1 machine) give the binaries from [1][2] a shot?

[...] They looked ok on my Intel MacBook.

[1] https://github.com/Frederick888/external-editor-revived/actions/runs/2648189295 https://github.com/Frederick888/external-editor-revived/actions/runs/2648189295 [2] https://github.com/Frederick888/external-editor-revived/releases/tag/untagged-ff629f64e2f3a70db82f https://github.com/Frederick888/external-editor-revived/releases/tag/untagged-ff629f64e2f3a70db82f [...] -- Dr. Eberhard W. Lisse \ / Obstetrician & Gynaecologist @.** / | Telephone: +264 81 124 6733 (cell) PO Box 8421 Bachbrecht \ / If this email is signed with GPG/PGP 10007, Namibia ;____/ Sect 20 of Act No. 4 of 2019 may apply

Frederick888 commented 2 years ago

Hmm... Link [2] was a test release that's in draft state. Perhaps it's not public.

No worries, it should be the same as the ones from [1].

ondohotola commented 2 years ago

Thank you, I just wanted to let you know :-)-O

Amazing work...

el

On 11/07/2022 14:00, Frederick Zhang wrote:

Hmm... Link [2] was a test release that's in draft state. Perhaps it's not public.

No worries, it should be the same as the ones from [1]. [...]

-- Dr. Eberhard W. Lisse \ / Obstetrician & Gynaecologist @.** / | Telephone: +264 81 124 6733 (cell) PO Box 8421 Bachbrecht \ / If this email is signed with GPG/PGP 10007, Namibia ;____/ Sect 20 of Act No. 4 of 2019 may apply

Frederick888 commented 2 years ago

A friend of mine helped me test this out on M1 :)

It was working as expected. Only friction was that because the binary wasn't signed, he needed to right click Open for the first time. xattr -c I usually do probably does the same thing, and I guess I can drop a small note in wiki.

And I added the targeting OS/arch to -v output, e.g.

$ ./external-editor-revived -v
External Editor Revived native messaging host for linux (x86_64) v0.2.0

(M1 should be macos (aarch64), M1 with Rosetta should be macos (x86_64) IIUC how Rosetta works.)

Let me know if you see different results when you test it. But I think it should be alright and I plan to get a new release out over the weekend.

ondohotola commented 2 years ago

As I wrote previously,

it is working on both arm64 and X86 with Monterey 12.4 and Thunderbird 91.11.0, using the Custom preferences using sh and

 /Applications/Alpha.app/Contents/Resources/alphac -w "/path/to/temp.eml"
 /Applications/TextMate.app/Contents/MacOS/mate -w "/path/to/temp.eml"

greetings, el

On 15/07/2022 10:39, Frederick Zhang wrote:

A friend of mine helped me test this out on M1 :)

It was working as expected. Only friction was that because the binary wasn't signed, he needed to right click Open for the first time. |xattr -c| I usually do probably does the same thing, and I guess I can drop a small note in wiki.

And I added the targeting OS/arch to |-v| output, e.g.

|$ ./external-editor-revived -v External Editor Revived native messaging host for linux (x86_64) v0.2.0 |

(M1 should be |macos (aarch64)|, M1 with Rosetta should be |macos (x86_64)| IIUC how Rosetta works.)

Let me know if you see different results when you test it. But I think it should be alright and I plan to get a new release out over the weekend. [...]

-- Dr. Eberhard W. Lisse \ / Obstetrician & Gynaecologist @.** / | Telephone: +264 81 124 6733 (cell) PO Box 8421 Bachbrecht \ / If this email is signed with GPG/PGP 10007, Namibia ;____/ Sect 20 of Act No. 4 of 2019 may apply

Frederick888 commented 2 years ago

No drama on 12.4 arm64/x86 with the pure x86 and also with the (experimental) Universal.

Ah, my brain somehow interpreted this as 'no drama on 12.4 arm64 [with Rosetta], [also no drama on] x86 with the pure x86 and also with the (experimental) Universal'.

All good then. Thanks again for the feedback.